Skip to content

docs(.github/pull_request_template): add checklist for running 'yarn run fix'#211

Merged
seungrodotlee merged 4 commits into
toss:mainfrom
sukvvon:docs/add-checklist-about-formatting-and-llinting-in-pr-template
Apr 24, 2025
Merged

docs(.github/pull_request_template): add checklist for running 'yarn run fix'#211
seungrodotlee merged 4 commits into
toss:mainfrom
sukvvon:docs/add-checklist-about-formatting-and-llinting-in-pr-template

Conversation

@sukvvon
Copy link
Copy Markdown
Contributor

@sukvvon sukvvon commented Apr 24, 2025

Overview

Checklist

  • Did you write the test code?
  • Have you run yarn run test:coverage to make sure there is no uncovered line?
  • Did you write the JSDoc?

@sukvvon sukvvon marked this pull request as draft April 24, 2025 07:25
@sukvvon sukvvon force-pushed the docs/add-checklist-about-formatting-and-llinting-in-pr-template branch from fe988be to 7ab86f5 Compare April 24, 2025 07:26
@sukvvon sukvvon force-pushed the docs/add-checklist-about-formatting-and-llinting-in-pr-template branch from 7ab86f5 to ea7e81d Compare April 24, 2025 07:26
@sukvvon sukvvon changed the title docs(.github/pull_request_template): add checklist for running 'pnpm run fix' docs(.github/pull_request_template): add checklist for running 'yarn run fix' Apr 24, 2025
@sukvvon sukvvon marked this pull request as ready for review April 24, 2025 07:27
Copy link
Copy Markdown
Contributor

@seungrodotlee seungrodotlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@seungrodotlee seungrodotlee merged commit aee4b50 into toss:main Apr 24, 2025
7 of 8 checks passed
@sukvvon sukvvon deleted the docs/add-checklist-about-formatting-and-llinting-in-pr-template branch April 24, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants